Bump to k8s 1.31 #664

ArangoGutierrez · 2024-10-15T15:14:52Z

I upgraded the K8s library versions to v1.31, and controller-tools to v0.16.4.

Fixes: #652

ArangoGutierrez · 2024-10-15T15:15:04Z

Supersedes #655

tenzen-y

Thanks!

tenzen-y · 2024-10-15T15:22:28Z

Makefile

-KUBECTL_VERSION=v1.30.4
-ENVTEST_K8S_VERSION=1.30.0
+KUBECTL_VERSION=v1.31.1
+ENVTEST_K8S_VERSION=1.31.1


Suggested change

ENVTEST_K8S_VERSION=1.31.1

ENVTEST_K8S_VERSION=1.31.0

It seems that the latest version is v1.30.0:

setup-envtest list (installed) v1.31.0 darwin/arm64 (installed) v1.30.0 darwin/arm64 (installed) v1.29.3 darwin/arm64 (installed) v1.29.1 darwin/arm64 (installed) v1.28.3 darwin/arm64 (installed) v1.27.1 darwin/arm64 (available) v1.30.0 darwin/arm64 (available) v1.29.3 darwin/arm64 (available) v1.29.1 darwin/arm64 (available) v1.29.0 darwin/arm64 (available) v1.28.3 darwin/arm64 (available) v1.28.0 darwin/arm64 (available) v1.27.1 darwin/arm64 (available) v1.26.1 darwin/arm64 (available) v1.26.0 darwin/arm64 (available) v1.25.0 darwin/arm64 (available) v1.24.2 darwin/arm64 (available) v1.24.1 darwin/arm64

tenzen-y · 2024-10-15T15:22:52Z

go.mod

@@ -1,18 +1,18 @@
 module github.com/kubeflow/mpi-operator

-go 1.22.0
+go 1.23.0


Suggested change

go 1.23.0

go 1.23

Could we eliminate the patch version?

tenzen-y

Thank you!
/lgtm
/approve

/hold for CI

tenzen-y · 2024-10-15T15:48:32Z

/lgtm

tenzen-y · 2024-10-15T15:53:37Z

/lgtm cancel

We need to upgrade the golangci-lint version.

mpi-operator/.github/workflows/golangci-lint.yml

Line 21 in ef9d049

version: v1.57.2
mpi-operator/Makefile

Line 141 in ef9d049

@GOBIN=$(PROJECT_DIR)/bin go install github.com/golangci/golangci-lint/cmd/[email protected]

tenzen-y · 2024-10-15T15:54:58Z

/approve cancel

tenzen-y · 2024-10-15T18:21:42Z

I chat with @ArangoGutierrez offline.
He is trying to resolve CI errors now.

tenzen-y · 2024-10-15T18:35:42Z

pkg/controller/mpi_job_controller.go

@@ -339,7 +339,7 @@ func NewMPIJobControllerWithClock(
 priorityClassSynced: priorityClassSynced,
 mpiJobLister: mpiJobInformer.Lister(),
 mpiJobSynced: mpiJobInformer.Informer().HasSynced,
- queue: workqueue.NewRateLimitingQueueWithConfig(workqueue.DefaultControllerRateLimiter(), workqueue.RateLimitingQueueConfig{Name: "MPIJobs"}),
+ queue: workqueue.NewTypedRateLimitingQueueWithConfig(workqueue.DefaultTypedControllerRateLimiter[any](), workqueue.TypedRateLimitingQueueConfig[any]{Name: "MPIJob"}),


I guess that we need to do this:

Suggested change

queue: workqueue.NewTypedRateLimitingQueueWithConfig(workqueue.DefaultTypedControllerRateLimiter[any](), workqueue.TypedRateLimitingQueueConfig[any]{Name: "MPIJob"}),

queue: workqueue.NewTypedRateLimitingQueueWithConfig(workqueue.DefaultTypedControllerRateLimiter[any](), workqueue.TypedRateLimitingQueueConfig[any]{Name: "MPIJob"}),

and then,

mpi-operator/pkg/controller/mpi_job_controller.go

Line 250 in dbcbfae

queue workqueue.RateLimitingInterface

workqueue.TypedRateLimitingInterface[any]

Modified my comment related to types.

yeah I was about to comment that any is required.

@ArangoGutierrez Could you address the Line 250 as I mentioned above?

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

tenzen-y · 2024-10-15T18:42:32Z

Additionally, I guess that we need to specify the 22.04:

mpi-operator/.github/workflows/main.yml

Line 6 in 86d09e3

runs-on: ubuntu-latest
mpi-operator/.github/workflows/mpi-operator-docker-image-publish.yml

Line 18 in 86d09e3

runs-on: ubuntu-latest
mpi-operator/.github/workflows/golangci-lint.yml

Line 12 in 86d09e3

runs-on: ubuntu-latest
mpi-operator/.github/workflows/codeql.yml

Line 23 in 86d09e3

runs-on: ubuntu-latest

tenzen-y · 2024-10-15T18:43:00Z

It seems that the latest ubuntu runner has many issues: https://github.com/actions/runner-images/issues?q=is%3Aissue+Ubuntu+24.04+runner

…[any] Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

tenzen-y · 2024-10-15T19:20:03Z

Could you try to change the installation URL in the following?

mpi-operator/Makefile

Line 149 in 86d09e3

 curl -L -o $(PROJECT_DIR)/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/${KUBECTL_VERSION}/bin/$(GOOS)/$(GOARCH)/kubectl 

curl -L -o $(PROJECT_DIR)/bin/kubectl https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/$(GOOS)/$(GOARCH)/kubectl

tenzen-y · 2024-10-15T19:30:06Z

test/e2e/e2e_suite_test.go

@@ -61,7 +61,7 @@ const (
 volcanoSchedulerManifestPath = rootPath + "/dep-manifests/volcano-scheduler/" // all in one yaml of volcano-development.yaml
 envUseExistingSchedulerPlugins = "USE_EXISTING_SCHEDULER_PLUGINS"
 envUseExistingVolcanoScheduler = "USE_EXISTING_VOLCANO_SCHEDULER"
- defaultSchedulerPluginsVersion = "v0.29.8"
+ defaultSchedulerPluginsVersion = "v0.31.1"


Suggested change

defaultSchedulerPluginsVersion = "v0.31.1"

defaultSchedulerPluginsVersion = "v0.29.8"

This is the scheduler-plugins version, not k8s version.

changed back

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

tenzen-y

Thank you!
This was not trival efforts!

/lgtm
/approve

google-oss-prow · 2024-10-15T19:52:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ArangoGutierrez · 2024-10-15T20:23:52Z

Thank you!

/lgtm

/approve

/hold for CI

Should we remove the hold?

tenzen-y · 2024-10-15T20:24:34Z

Yup
/hold cancel

google-oss-prow bot added the do-not-merge/work-in-progress label Oct 15, 2024

google-oss-prow bot requested review from gaocegege and zw0610 October 15, 2024 15:14

google-oss-prow bot added the size/XXL label Oct 15, 2024

ArangoGutierrez marked this pull request as ready for review October 15, 2024 15:15

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 15, 2024

google-oss-prow bot requested a review from carmark October 15, 2024 15:15

tenzen-y reviewed Oct 15, 2024

View reviewed changes

ArangoGutierrez force-pushed the devel/k8s131 branch from 41fa348 to cc09222 Compare October 15, 2024 15:25

ArangoGutierrez requested a review from tenzen-y October 15, 2024 15:25

tenzen-y reviewed Oct 15, 2024

View reviewed changes

google-oss-prow bot added the do-not-merge/hold label Oct 15, 2024

google-oss-prow bot assigned tenzen-y Oct 15, 2024

google-oss-prow bot added lgtm approved labels Oct 15, 2024

ArangoGutierrez force-pushed the devel/k8s131 branch from cc09222 to 17fbb2c Compare October 15, 2024 15:47

google-oss-prow bot removed the lgtm label Oct 15, 2024

google-oss-prow bot added the lgtm label Oct 15, 2024

tenzen-y mentioned this pull request Oct 15, 2024

Release v0.6.0 requirements #654

Open

7 tasks

google-oss-prow bot removed the lgtm label Oct 15, 2024

google-oss-prow bot removed the approved label Oct 15, 2024

ArangoGutierrez requested a review from tenzen-y October 15, 2024 18:25

tenzen-y reviewed Oct 15, 2024

View reviewed changes

ArangoGutierrez force-pushed the devel/k8s131 branch from dbcbfae to 4ef8cda Compare October 15, 2024 18:39

Bump to k8s 1.31

a209ebb

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez added 2 commits October 15, 2024 20:42

Bump sigs.k8s.io/controller-runtime to v0.19.0

46f385e

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Bump golangci-lint to v1.61.0

9d5efd8

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez force-pushed the devel/k8s131 branch from 4ef8cda to 9d5efd8 Compare October 15, 2024 18:42

ArangoGutierrez requested a review from tenzen-y October 15, 2024 18:44

change queue from RateLimitingInterface to TypedRateLimitingInterface…

8946762

…[any] Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez force-pushed the devel/k8s131 branch from dbbcc72 to 8946762 Compare October 15, 2024 19:07

tenzen-y reviewed Oct 15, 2024

View reviewed changes

Update kubectl url

16d56d1

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez force-pushed the devel/k8s131 branch from 5d2a265 to 16d56d1 Compare October 15, 2024 19:30

tenzen-y reviewed Oct 15, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Oct 15, 2024

google-oss-prow bot added the approved label Oct 15, 2024

google-oss-prow bot removed the do-not-merge/hold label Oct 15, 2024

google-oss-prow bot merged commit a869150 into kubeflow:master Oct 15, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to k8s 1.31 #664

Bump to k8s 1.31 #664

ArangoGutierrez commented Oct 15, 2024 •

edited by tenzen-y

Loading

ArangoGutierrez commented Oct 15, 2024

tenzen-y left a comment

tenzen-y Oct 15, 2024

ArangoGutierrez Oct 15, 2024

tenzen-y Oct 15, 2024

ArangoGutierrez Oct 15, 2024

tenzen-y left a comment

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024 •

edited

Loading

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

tenzen-y Oct 15, 2024 •

edited

Loading

tenzen-y Oct 15, 2024

ArangoGutierrez Oct 15, 2024

tenzen-y Oct 15, 2024

ArangoGutierrez Oct 15, 2024

tenzen-y commented Oct 15, 2024 •

edited

Loading

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

tenzen-y Oct 15, 2024

ArangoGutierrez Oct 15, 2024

tenzen-y left a comment

google-oss-prow bot commented Oct 15, 2024

ArangoGutierrez commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

	queue: workqueue.NewTypedRateLimitingQueueWithConfig(workqueue.DefaultTypedControllerRateLimiter[any](), workqueue.TypedRateLimitingQueueConfig[any]{Name: "MPIJob"}),
	queue: workqueue.NewTypedRateLimitingQueueWithConfig(workqueue.DefaultTypedControllerRateLimiter[any](), workqueue.TypedRateLimitingQueueConfig[any]{Name: "MPIJob"}),

	defaultSchedulerPluginsVersion = "v0.31.1"
	defaultSchedulerPluginsVersion = "v0.29.8"

Bump to k8s 1.31 #664

Bump to k8s 1.31 #664

Conversation

ArangoGutierrez commented Oct 15, 2024 • edited by tenzen-y Loading

ArangoGutierrez commented Oct 15, 2024

tenzen-y left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tenzen-y left a comment

Choose a reason for hiding this comment

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024 • edited Loading

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

tenzen-y Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tenzen-y commented Oct 15, 2024 • edited Loading

tenzen-y commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tenzen-y left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Oct 15, 2024

ArangoGutierrez commented Oct 15, 2024

tenzen-y commented Oct 15, 2024

ArangoGutierrez commented Oct 15, 2024 •

edited by tenzen-y

Loading

tenzen-y commented Oct 15, 2024 •

edited

Loading

tenzen-y Oct 15, 2024 •

edited

Loading

tenzen-y commented Oct 15, 2024 •

edited

Loading